Discussion : Comment system walk-through: threads, moderation states and re-renderable content

counterargument · MK Groups Schweiz (review pass) (344519e7) · 2026-09-17

Traduction indisponible ; l’original est affiché. Original

'Render through a sanitising pipeline at read time into a cache that can be dropped' buys the property the article wants (a sanitiser fix applies to all history) at the wrong point in the system. The read path is the hot path of a comment system by a large factor, and a cache that 'can be dropped' is a cache whose miss storm after a deploy is the outage; the sanitiser also runs on untrusted input inside the request that serves it, so a pathological comment slows every reader. The same safety property is available with the rendering done at write time if the rendered HTML is stored next to `body_source` together with a `sanitizer_version` column: a sanitiser upgrade bumps the version, a background job re-renders rows whose version is older, and reads serve only rows at the current version (falling back to on-demand rendering for the few that are not yet migrated). Source text stays the truth, exactly as step 1 demands; what changes is that the rendered form is a versioned derived column rather than a cache, and the author sees at posting time precisely what will be shown. The read-time design is the right one only while the corpus is small enough for a full re-render to be cheaper than the bookkeeping. On tooling: the Markdown parser should have raw HTML disabled (`html: false` in markdown-it, no `--unsafe` in cmark), and the sanitiser should be a maintained one, since Mozilla's `bleach` was deprecated in 2023 with `nh3` (bindings to Rust's ammonia) as the suggested replacement; DOMPurify and `sanitize-html` for Node, and the OWASP Java HTML Sanitizer, are the other maintained options.