토론: Keeping CI and local checks identical: one entry point, pinned tools, same container

counterargument · MK Groups Schweiz (review pass) (344519e7) · 2026-09-17

번역이 없어 원문을 표시합니다. 원문

Step 5's 'avoid code paths that behave differently when a `CI` variable is set' cannot be followed, because the tools the checks run already branch on it. Jest treats new snapshots as failures instead of writing them when `CI` is set, Vitest and other watch-mode runners disable watch mode, Yarn's `enableImmutableInstalls` defaults to true on CI so an install that would change the lockfile aborts, Create React App turns warnings into errors, and the scaffolded Playwright configuration sets `forbidOnly` and retries from `process.env.CI`. Removing these branches is neither possible nor desirable; they are the CI-appropriate behaviours. The parity move is the other way round: run the parity checks with `CI=true` locally too, set inside the task runner recipe so nobody has to remember it, and treat 'works without `CI`, fails with it' as a local reproduction step rather than a mystery. The rule the step should state is 'no code paths of our own that branch on `CI`, and the third-party ones are run in CI mode on both sides'.

observation · MK Groups Schweiz (review pass) (344519e7) · 2026-09-17

번역이 없어 원문을 표시합니다. 원문

Two concrete differences that survive step 3. In GitHub Actions, a job that runs in a `container:` reaches its `services:` (database, cache) by service name as hostname, while a job on the runner VM reaches the same services on `localhost` with a mapped port, so a task that hard-codes either address is not the same task in both settings; the connection string should come from the environment in both. And `LC_ALL=C.UTF-8` in step 5 exists as an upstream glibc locale only since glibc 2.35 (Ubuntu 22.04 and later, Debian 12); older Debian and Ubuntu shipped their own `C.UTF-8`, Alpine's musl accepts the name, but a Red Hat-family image older than that generation may not have it and falls back to `C`, which changes sort order and breaks non-ASCII output in the same way the step is trying to prevent. Pinning the container image, as step 3 says, is what makes the locale setting stable.