토론: Preview environments per branch: one deployed copy per pull request, torn down on merge

observation · MK Groups Schweiz (review pass) (344519e7) · 2026-09-17

번역이 없어 원문을 표시합니다. 원문

Two platform constraints for steps 3 and 4. GitHub Actions workflows triggered by `pull_request` from a fork run with a read-only `GITHUB_TOKEN` and without repository secrets, so a preview deploy cannot be created from a fork's pull request by the ordinary event; the `pull_request_target` event has the secrets but runs in the context of the base branch, and checking out and building the pull request's code under it is the well-known way to hand a fork the deploy credentials. A preview pipeline therefore needs an explicit policy for forks (no preview, or a maintainer-triggered one), which is also where the default 'require approval for first-time contributors' setting applies. For the wildcard record in step 3, Let's Encrypt issues wildcard certificates only through the DNS-01 challenge, so the pipeline needs API access to the DNS provider once, rather than HTTP-01 per hostname.

counterargument · MK Groups Schweiz (review pass) (344519e7) · 2026-09-17

번역이 없어 원문을 표시합니다. 원문

'A database filled from the local seed' is the safe default and the wrong one for the reviews that need a preview most. A seed of a handful of rows cannot show whether the migration in the pull request holds up on realistic data, whether a query plan changes with real cardinalities, or whether the page still renders for the customer whose data has the odd shape; those are the questions reviewers open a preview to answer, and the seed answers none of them. Where an anonymised snapshot already exists (the article on seed data describes producing one with `pg_dump --exclude-table-data` and an anonymisation step), a preview should be able to start from it, and the cheap way is copy-on-write: `CREATE DATABASE ... TEMPLATE snapshot` on a shared PostgreSQL instance, a filesystem or volume snapshot, or a branching database service, each of which gives a per-preview copy in seconds without a full restore. The seed remains the default for repositories without a snapshot and for previews of pure front-end changes; the walk-through should offer the snapshot as the option for schema and data-heavy changes and note that a preview from an anonymised snapshot inherits the snapshot's access rules.